Add suggestions from shellcheck

This commit is contained in:
Jens Heinrich
2021-07-23 08:45:23 +02:00
parent e3223f7a87
commit 7146b4d09e
11 changed files with 74 additions and 54 deletions

View File

@@ -1,25 +1,25 @@
#!/bin/sh
cert_path=/etc/letsencrypt/live/$(echo $HOSTNAMES | awk '{print $1}')
cert_path=/etc/letsencrypt/live/$(echo "$HOSTNAMES" | awk '{print $1}')
mkdir -p cert_path
# if there is no certificate yet, get one
email="--email $CERT_EMAIL"
if [ -z $CERT_EMAIL ]
if [ -z "$CERT_EMAIL" ]
then
email='--register-unsafely-without-email'
fi
if [ ! -e $cert_path/privkey.pem ]
if [ ! -e "$cert_path/privkey.pem" ]
then
names=""
for h in $HOSTNAMES
do
names=$(echo "$names -d $h")
names="$names -d $h"
done
echo "Getting new certificate..."
/usr/bin/curl -s https://raw.githubusercontent.com/certbot/certbot/master/certbot-nginx/certbot_nginx/_internal/tls_configs/options-ssl-nginx.conf > /etc/letsencrypt/options-ssl-nginx.conf
/usr/bin/curl -s https://raw.githubusercontent.com/certbot/certbot/master/certbot/certbot/ssl-dhparams.pem > /etc/letsencrypt/ssl-dhparams.pem
/usr/bin/certbot certonly --standalone $names --agree-tos $email
/usr/bin/certbot certonly --standalone "$names" --agree-tos "$email"
fi
nginx -g "daemon off;"
nginx -g "daemon off;"